On Sun, Dec 01, 2013 at 12:15:07PM -0700, Stephen Warren wrote: > On 11/29/2013 06:00 AM, Thierry Reding wrote: > > On Fri, Nov 15, 2013 at 01:53:59PM -0700, Stephen Warren wrote: [...] > >> reg = <0x70080300 0x100>; nvidia,ahub-cif-ids = <4 4>; clocks = > >> <&tegra_car TEGRA114_CLK_I2S0>; > > > > The clocks for these i2s devices are already listed in the ahub > > node. Is that on purpose? > > Yes. > > The AHUB driver needs to remove reset from the HW modules, so that the > configlink bus works. Reset removal used to require a custom Tegra API > that took a clock as a parameter. Hence, the AHUB node needed the > clock reference. After this series, the AHUB only needs a reset handle > to use the standard reset API. However, the clock references are left > in the AHUB node until after the AHUB driver is converted, so the > series is bisectable. After the series, only the I2S driver needs to > clock references. [...] > >> + <&tegra_car 30>, /* i2s0 */ + > >> <&tegra_car 11>, /* i2s1 > >> */ + <&tegra_car 18>, /* i2s2 */ + > >> <&tegra_car 101>, /* > >> i2s3 */ + <&tegra_car 102>, /* i2s4 */ > > > > Some comment for these as for Tegra20. > > I'm not sure which other comment was "for Tegra20", since none of the > filenames were quoted, but I'll try to check when I get back.
Indeed. I didn't quote the filenames. =( And I typoed Tegra114 as Tegra20. I was referring to the "I2S clocks are listed in both the AHUB and I2S nodes" comment above for Tegra114. From your earlier reply, though this looks good then. Thierry
pgpevSXIYUVel.pgp
Description: PGP signature
