On Tue, Dec 03, 2013 at 11:15:50AM -0700, Stephen Warren wrote: [...] > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c [...] > @@ -986,7 +1014,8 @@ static struct dma_async_tx_descriptor > *tegra_dma_prep_slave_sg( > > sg_req->ch_regs.apb_ptr = apb_ptr; > sg_req->ch_regs.ahb_ptr = mem; > - sg_req->ch_regs.csr = csr | ((len - 4) & 0xFFFC); > + sg_req->ch_regs.csr = csr; > + tegra_dma_prep_wcount(tdc, &(sg_req->ch_regs), len);
The parentheses aren't required here. > sg_req->ch_regs.apb_seq = apb_seq; > sg_req->ch_regs.ahb_seq = ahb_seq; > sg_req->configured = false; > @@ -1115,7 +1144,8 @@ static struct dma_async_tx_descriptor > *tegra_dma_prep_dma_cyclic( > ahb_seq |= get_burst_size(tdc, burst_size, slave_bw, len); > sg_req->ch_regs.apb_ptr = apb_ptr; > sg_req->ch_regs.ahb_ptr = mem; > - sg_req->ch_regs.csr = csr | ((len - 4) & 0xFFFC); > + sg_req->ch_regs.csr = csr; > + tegra_dma_prep_wcount(tdc, &(sg_req->ch_regs), len); Nor here. Other than that, looks good to me: Reviewed-by: Thierry Reding <[email protected]> And since I've had this same patch in my tree for a while: Tested-by: Thierry Reding <[email protected]>
pgpcZJLgtvWIG.pgp
Description: PGP signature
