This could silently fail which leads to surprising behaviour.

Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <[email protected]>
---
 src/set.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/set.c b/src/set.c
index ff32b53..907d640 100644
--- a/src/set.c
+++ b/src/set.c
@@ -59,7 +59,11 @@ read_from_image(char *filename,
                return result;
        }
 
-       fseek(fp, offset, SEEK_SET);
+       if (fseek(fp, offset, SEEK_SET) == -1) {
+               printf("Error: Couldn't seek to %s(%d)\n", filename, offset);
+               result = 1;
+               goto cleanup;
+       }
 
        if (stat(filename, &stats) != 0) {
                printf("Error: Unable to query info on bootloader path %s\n",
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to