When register_virtio_device() fails in virtio_uml_probe(),
the code sets vu_dev->registered = 1 even though
the device was not successfully registered.
This can lead to use-after-free or other issues.

Fixes: 04e5b1fb0183 ("um: virtio: Remove device on disconnect")
Signed-off-by: Miaoqian Lin <linmq...@gmail.com>
---
 arch/um/drivers/virtio_uml.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c
index ad8d78fb1d9a..c402c4cc908a 100644
--- a/arch/um/drivers/virtio_uml.c
+++ b/arch/um/drivers/virtio_uml.c
@@ -1250,8 +1250,10 @@ static int virtio_uml_probe(struct platform_device *pdev)
        device_set_wakeup_capable(&vu_dev->vdev.dev, true);
 
        rc = register_virtio_device(&vu_dev->vdev);
-       if (rc)
+       if (rc) {
                put_device(&vu_dev->vdev.dev);
+               return rc;
+       }
        vu_dev->registered = 1;
        return rc;
 
-- 
2.25.1


Reply via email to