[linux-usb-devel] [PATCH] USB Omninet copy_to_user bug fix

[Greg KH]

Hi,

Here's a patch from that fixes the copy_*_user bug that Dawson Engler
found in the omninet driver.  It is against 2.4.3-pre4.

thanks,

greg k-h

-- 
greg@(kroah|wirex).com

diff -Naur -X dontdiff linux-2.4.3-pre4/drivers/usb/serial/omninet.c 
linux-2.4.3-pre4-greg/drivers/usb/serial/omninet.c
--- linux-2.4.3-pre4/drivers/usb/serial/omninet.c       Thu Feb 22 23:43:26 2001
+++ linux-2.4.3-pre4-greg/drivers/usb/serial/omninet.c  Mon Mar 19 13:59:12 2001
@@ -305,8 +305,6 @@
                return (0);
        }
 
-       usb_serial_debug_data (__FILE__, __FUNCTION__, count, buf);
-       
        spin_lock_irqsave (&port->port_lock, flags);
        
        count = (count > OMNINET_BULKOUTSIZE) ? OMNINET_BULKOUTSIZE : count;
@@ -318,6 +316,7 @@
                memcpy (wport->write_urb->transfer_buffer + OMNINET_DATAOFFSET, buf, 
count);
        }
 
+       usb_serial_debug_data (__FILE__, __FUNCTION__, count, 
+wport->write_urb->transfer_buffer);
 
        header->oh_seq  = od->od_outseq++;
        header->oh_len  = count;