Johannes Erdfelt wrote:
>
> On Mon, Apr 16, 2001, johan verrept <[EMAIL PROTECTED]> wrote:
> > The only reason I see for this is that the list spinlock is held during
> > the entire usb_hub_events() call and that would cause hub_irq() to block.
> > The locking on the eventlist could be made finer (releasing the spinlock
> > as soon as the event has been dequeued) and done irqsave. The check to
> > see if the waitqueue is active in hub_irq() can be removed.
This is wrong btw, the locking is fine.
> > Is this correct and/or desirable?
>
> You are right, this is a bug. I think the correct fix is to move the
> waitqueue_active check to after we add the hub to the event list. The
> hub must be added to the event list regardless so it can be processed.
>
> I'll submit a patch along those lines.
kewl,
J.
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
