On Fri, 4 May 2001, Stefan Nilsen wrote:

> I have here a patch against usbvideo (as found on the linux-usb cvs 
> repository) for webcamgo.

Do you want to put it into CVS at SF? Do you have developer's access?
I don't think so, you are not listed there.

> I would like someone having a Webcam Go camera to test this patch and see if 
> it generates any data when making a 
> cat /dev/video0 > /tmp/videodata

No such camera here. You will get all the fun decoding :-)

You send commands to the camera in probe() routine. This is BAD, and
that's why I have flag "is_initialized" - to be tested in open() handler
and the init invoked. This is because of several reasons:

- initialization is LONG. During this time all other plug/unplug events on
  the bus will not be handled (remember who calls probe()!)

- you _may_ need to initialize camera on each open() - or maybe sometimes,
  if for example it loses its settings...

That's why I recommend to move initialization from probe() routine.

Cheers,
Dmitri

-- 
Curiousity killed the cat but at least it didn't die ignorant.


_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to