Greetings!

I diffed printer.c in 2.2.18 and 2.2.19 and it seems to me that
something wrong happened to it. Look at this:

--- linux-2.2.18/drivers/usb/printer.c  Sun Dec 10 16:49:43 2000
+++ linux-2.2.19/drivers/usb/printer.c  Sun Mar 25 08:37:37 2001
@@ -366,18 +474,13 @@
                   (interface->bInterfaceProtocol > 1 && interface->bNumEndpoints < 2))
                        continue;
 
-               if (alts == -1)
-                       alts = i;
-
-               if (!bidir && interface->bInterfaceProtocol > 1) {
+               if (interface->bInterfaceProtocol > 1) {
                        bidir = 1;
                        alts = i;
+                       break;
                }
        }
 
-       if (alts == -1)
-               return NULL;
-
        interface = &dev->actconfig->interface[ifnum].altsetting[alts];
        if (usb_set_interface(dev, ifnum, alts))
                err("can't set desired altsetting %d on interface %d", alts, ifnum);

If we lived in Japan, the author of this would need to perform
Hara-kiri (to himself, naturally), because now printer claims every
helpless device that it finds.

Revert that, please.

-- Pete

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to