Hi Martin,

> I've just re-run the test which triggered the BUG() for me with your
> ohci-0508 patch applied. Works fine for me, no BUG() or other problems
> encountered. However, IMHO it is not the whole story yet. ...
> 
> ... One path however is urb_free_priv() -> td_free() which
> is unprotected in some out-on-error cases in sohci_submit_urb(). 

Yes, you're right -- and it looks like your patch is a reasonable fix for
that oversight.  Basically, sohci_submit_urb() needs to grab the lock
sooner and keep it.  

> Below, I've included the patch (to be applied after your ohci-0508!).
> Tested as before, i.e. not covering the error path (would require an
> iso/int overallocation situation).

I'll see about integrating them into one patch and submitting it ... though
testing for the readl() paths would be nice too.  (MediaGX, mostly.)

- Dave



_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to