> I had to look at usb-uhci and locking in it once again;
> this time I know what is wrong with David-B's "fix"
> <http://marc.theaimsgroup.com/?l=linux-usb-devel&m=98580988401128&w=2>
Hey, all I claimed to do was fix an oops I'd been hitting.
Are you claiming I was imagining the oops, and then its
removal? :)
> I suggest we get rid of any instances of urb->lock in usb-uhci.
> It does not serve any useful purpose, and is a terrible bug
> generator.
The "hcd" layer (used right now only for EHCI) uses that
lock when it's switching urbs between the generic layer
(what the USB spec calls the "USBD" ... think "usbcore")
and the HCD. It helps prevent racing between unlinking
because of device driver request, and because of the HC
completing the request (perhaps because the HC itself
died or got rmmodded -- not just normal completions).
So I'm not quite sure that urb->lock can really disappear.
Though I'd agree that it's one of several chunks of urb data
that aren't clearly enough specified.
- Dave
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
