On Sun, Jun 17, 2001 at 08:22:51PM +0200, Wolfgang M?es wrote:
> On Sunday, 17. June 2001 16:18, David Brownell wrote:
>
> [spin_lock_init in usb_alloc_urb()]
>
> > I'm not sure I see what the deal is. The FILL_*_URB() macros
> > initialize URBs, including doing the spin lock init.
>
> I was not aware of this...
> So spin_lock_init() ist doubled: once in usb_alloc_urb(), once
> in FILL_*_URB().
>
> It is save to call spin_lock_init() twice for each architecture?
Yes, if you don't do it while the spinlock is in use.
> > So there is
> > already an API functionality to do this; allocation and init are
> > already separated.
>
> So let's drop the init in usb_alloc_urb()?
FILL_* were originally intended to be just convenience macros, not a
part of the API.
--
Vojtech Pavlik
SuSE Labs
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
