> 1. You use interruptible_sleep_on in get_registers() which could potentially
> lose a wakeup.

Right. Now i am using the timeout version of the call. For now it seems
it works.

> 2. There is no need to check a waitqueue for waiters. Simply wake them up
> unconditionally.

I am afraid this could be dangerous, especially if sleep_on() have
returned
before callback is called. I checked wake_up code and didn't see any
check if the queue is empty.

Thanks for the feedback.


later,
Petko

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to