Roman Weissgaerber wrote: > Li Yi wrote: > > > > Hi, Roman, > > > > I got two questions regarding your patch on isp1161 driver. > > 1. What will happen if the length is 1 byte in the READ_REGn16 function? > > OK, Seems to be a bug ;) As I used to read PTD and payload separately, I got that concern. > > > > 2.As not much embedded device will use this kind of ISA card( hcport = > > 0x290), they may directly map those registers into memory and can do 1 step > > reading with FPGA assistant, is that better to define some general macro like > > GET_GRAME_NUMBER(hci) instead of calling READ_REG(hci, **) directly? > > > > The READ_REG functions was replacements for the pci read and write > functions of the OHCI root-hub. So they should have been macros > in order to share the code between OHCI root-hub and isp1161 root-hub. > But then it was faster to write the functions and care about > direct code sharing with OHCI later. > Anyway, I am open to change it in any direction. > But I don't think we should use general macros like (GET_RH_STATUS) > because > even if you use memory addressing you have to address the chip-registers > in > a systematic way. > My case is that FPGA help me doing the addressing and reading in hardware which eliminate those time problems, maybe I am lucky to have a good hardware engineer beside. I just start porting your patch on my board and will bother you later, :) Thanks, Li Yi > > BTW. the GET_FRAME_NUMBER macro is there because hc_simple.c is a > generic > simple frontend for embedded USB host controllers so I have to abstract > that > call there. > > regards > > Roman >
begin:vcard n:Li;Yi tel;fax:+65-481-6997 tel;work:+65-486-3796 x-mozilla-html:FALSE org:Global Software Group, Embedded System ;<html> <img src="http://SL.sps.mot.com/images/MotLogo-rotating_sm.gif";> </html> version:2.1 email;internet:[EMAIL PROTECTED] title:Sotftware Engineer adr;quoted-printable:;;Singapore Software Center=0D=0AMotorola Innovation Centre - Level 3A=0D=0A12 Ang Mo Kio Street 64=0D=0A;Singapore;;569088;Singapore fn:Yi Li end:vcard
![http://SL.sps.mot.com/images/MotLogo-rotating_sm.gif"](http://SL.sps.mot.com/images/MotLogo-rotating_sm.gif"){kind=link}