On Mon, Sep 24, 2001 at 05:39:19PM +1000, Brad Hards wrote:
> Greg KH wrote:
> Having looked at the acm_probe() code, I note that there is an explicit check
> for protocol of 1 (which is the AT command set, I think - I really need to
> find my copy of the CDC spec...), so the table could be
> SB_DEVICE_ID_MATCH_INT_INFO(USB_CLASS_COMM, 2, 1), and then we could simply
> remove the check in acm_probe():
> if (ifcom->bInterfaceClass != 2 || ifcom->bInterfaceSubClass != 2 ||
> ifcom->bInterfaceProtocol != 1 || ifcom->bNumEndpoints < 1)
> continue;
>
> Makes no real difference - just so long as the acm driver doesn't claim
> CDCEther devices, and vice versa.
>
> Do you want another patch?
Yeah, a cleaner patch, removing that check would be great.
And make it against 2.4.10, since your patch made it into there, going
around the maintainer's back, not nice :)
thanks,
greg k-h
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
