On Fri, Oct 19, 2001, Greg KH <[EMAIL PROTECTED]> wrote:
> In compiling the latest version of uhci.c, I get a compiler warning:
> uhci.c: In function `uhci_unlink_generic':
> uhci.c:1688: warning: suggest parentheses around && within ||
>
> In looking at the code in question, I'm not sure where you want to put
> the ():
>
> /* Control and Isochronous ignore the toggle, so this */
> /* is safe for all types */
> if (!(td->status & TD_CTRL_ACTIVE) &&
> uhci_actual_length(td->status) < uhci_expected_length(td->info)
>||
> tmp == head) {
> usb_settoggle(urb->dev, uhci_endpoint(td->info),
> uhci_packetout(td->info),
> uhci_toggle(td->info) ^ 1);
> }
>
> Any hints?
Woops. It should looke like this:
if (!(td->status & TD_CTRL_ACTIVE) &&
(uhci_actual_length(td->status) < uhci_expected_length(td->info) ||
tmp == head)) {
Essentially, if (this TD finished) and (was short || the last TD) then...
JE
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
