On Wed, Nov 28, 2001 at 10:11:27PM +0530, Masoodur Rahman wrote:
> 
> Greg,
>     Are u going to update the usb bluetooth driver with the (struct
> semaphore lock) member in the struct usb_bluetooth . This should be put in
> place for
> (a) bluetooth_open()
> (b) usb_bluetooth_disconnect()
> (c) bluetooth_close())
> while submitting and unlinking/freeing URBs
> 
> This would some of the frequent  crashes , i hope.

I wasn't aware of any crashes.  Are you only having problems on a SMP
machine?

Yes, a semaphore should be used in these functions, as we had previously
talked about.

> Apart from that, i don't see any reason for us to retain BTBUGGYHARDWARE.
> Or are there any hardware which needs it to be turned?

There are lots of buggy USB Bluetooth hardware out there :)
Unfortunately I don't think it's going away any time soon.  Mark knows
what hardware needs that #define.

> The double initialisation of the FILL_INT_URB/FILL_BULK_URB  in
> usb_bluetooth_probe and bluetooth_open also needs to be corrected.

Why?  It doesn't hurt anything.

On Wed, Nov 28, 2001 at 10:17:33PM +0530, Masoodur Rahman wrote:
> hi,
>   Sorry for missing out in the last mail ...
>      Greg, I think we also ought to remove the bluetooth->active check
>      done
> at all the places ?   ( ur idea itself .............)

bluetooth->active should be changed to a open_count, so that the port
can be opened multiple times.  See the usb-serial drivers for how this
should be done.

Are you having problems with more than one client trying to open the
port?

For all of these issues, patches are always welcome :)

thanks,

greg k-h

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to