Hi,

Here's a patch against 2.4.12-ac3 by David Brownell that changes the
error messages of the UHCI drivers to show the difference between a
stall and babble.

thanks,

greg k-h



diff --minimal -Nru a/Documentation/usb/error-codes.txt 
b/Documentation/usb/error-codes.txt
--- a/Documentation/usb/error-codes.txt Wed Oct 17 00:06:38 2001
+++ b/Documentation/usb/error-codes.txt Wed Oct 17 00:06:38 2001
@@ -79,8 +79,7 @@
 -EILSEQ                        CRC mismatch
 
 USB_ST_STALL
--EPIPE                 a) babble detect
-                       b) endpoint stalled
+-EPIPE                 endpoint stalled
 
 USB_ST_BUFFEROVERRUN
 -ECOMM                 During an IN transfer, the host controller
@@ -95,7 +94,7 @@
 USB_ST_DATAOVERRUN
 -EOVERFLOW             The amount of data returned by the endpoint was
                        greater than either the max packet size of the
-                       endpoint or the remaining buffer size
+                       endpoint or the remaining buffer size.  "Babble".
 
 USB_ST_DATAUNDERRUN
 -EREMOTEIO             The endpoint returned less than max packet size
diff --minimal -Nru a/drivers/usb/uhci.c b/drivers/usb/uhci.c
--- a/drivers/usb/uhci.c        Wed Oct 17 00:06:38 2001
+++ b/drivers/usb/uhci.c        Wed Oct 17 00:06:38 2001
@@ -796,7 +796,7 @@
        if (status & TD_CTRL_NAK)                       /* NAK */
                return -ETIMEDOUT;
        if (status & TD_CTRL_BABBLE)                    /* Babble */
-               return -EPIPE;
+               return -EOVERFLOW;
        if (status & TD_CTRL_DBUFERR)                   /* Buffer error */
                return -ENOSR;
        if (status & TD_CTRL_STALLED)                   /* Stalled */
diff --minimal -Nru a/drivers/usb/usb-uhci.c b/drivers/usb/usb-uhci.c
--- a/drivers/usb/usb-uhci.c    Wed Oct 17 00:06:38 2001
+++ b/drivers/usb/usb-uhci.c    Wed Oct 17 00:06:38 2001
@@ -2193,7 +2193,7 @@
        if (status & TD_CTRL_NAK)       /* NAK */
                return -ETIMEDOUT;
        if (status & TD_CTRL_BABBLE)    /* Babble */
-               return -EPIPE;
+               return -EOVERFLOW;
        if (status & TD_CTRL_DBUFERR)   /* Buffer error */
                return -ENOSR;
        if (status & TD_CTRL_STALLED)   /* Stalled */

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to