Am Sonntag 02 Dezember 2001 03:34 schrieb Greg KH:
> On Sun, Dec 02, 2001 at 01:50:45AM +0100, Oliver Neukum wrote:
> > * v0.9 - fix unplug-while-open paths
> > + * v0.10 - remove sleep_on and add module reference counting
> > ([EMAIL PROTECTED])
>
> Your editor is putting spaces in the place of tabs, can you please fix
> that?
I'll try to. KDE loves doing that.
> > @@ -371,31 +396,46 @@
> > {
> > struct usblp *usblp = file->private_data;
> > int timeout, err = 0, writecount = 0;
> > + DECLARE_WAITQUEUE(wait, current);
>
> Why mess with all of this? If you use a urb pool, and the BULK_QUEUE
> flag, all of the sleeping and WAITQUEUE stuff goes away. Since all of
> the host controller drivers work great for BULK_QUEUE, I'd like to see
> more drivers use it. It simplifies things greatly.
Here I don't understand you. Certainly an URB pool could be used. But why
would it prevent needing to wait. IMHO it would just mean waiting for a pool
of URBs to finish instead of waiting for a single URB.
And frankly it would take a lot of change to the internal logic of the driver.
I don't see the gain justifying it.
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
