Hi,
I see no problem with this patch,
Johannes can you apply this patch?
Jeroen
On Tue, 04 Dec 2001 17:25:45 -0800 (PST), Chris Rankin <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> I was poking around with the USB code and I noticed that the SE401
> module used the old Linux 2.2-style module locking. I have created a
> patch which I *think* will update the driver to 2.4-style module
> locking, but unfortunately I don't have any such hardware to test
> with. However, I can at least verify that it compiles :-).
>
> The patch also removes what appears to be a redundant declaration of
> the se401_driver structure. The full patch is included below.
>
> Cheers,
> Chris
>
> --- linux-2.4.16/drivers/usb/se401.c.orig Tue Dec 4 17:09:44 2001
> +++ linux-2.4.16/drivers/usb/se401.c Tue Dec 4 17:16:10 2001
> @@ -73,9 +73,6 @@
> EXPORT_NO_SYMBOLS;
>
>
> -static struct usb_driver se401_driver;
> -
> -
> /**********************************************************************
> *
> * Memory management
> @@ -1056,14 +1053,12 @@
> int err = 0;
>
> /* we are called with the BKL held */
> - MOD_INC_USE_COUNT;
>
> se401->user=1;
> se401->fbuf=rvmalloc(se401->maxframesize * SE401_NUMFRAMES);
> if(!se401->fbuf) err=-ENOMEM;
>
> if (err) {
> - MOD_DEC_USE_COUNT;
> se401->user = 0;
> }
>
> @@ -1092,8 +1087,6 @@
> se401 = NULL;
> info("device unregistered");
> }
> -
> - MOD_DEC_USE_COUNT;
> }
>
> static int se401_init_done(struct video_device *dev)
> @@ -1391,6 +1384,7 @@
> }
>
> static struct video_device se401_template = {
> + owner: THIS_MODULE,
> name: "se401 USB camera",
> type: VID_TYPE_CAPTURE,
> hardware: VID_HARDWARE_SE401,
>
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
