Johannes Erdfelt <[EMAIL PROTECTED]> writes:
> usb-uhci.c looks good as far as reference counting. The core looks
> clean. The hub driver looks clean. Atleast in 2.4.13. I should check
> 2.5.2-pre6.
I don't think this is directly related to my problem, but I think
there is a ref counting bug in an error path in usb-storage. Is the
following patch correct?
--- storage/usb.c.old Sat Jan 5 11:17:59 2002
+++ storage/usb.c Sat Jan 5 11:18:29 2002
@@ -951,6 +951,7 @@
ss->protocol_name = "Unknown";
kfree(ss->current_urb);
kfree(ss);
+ usb_dec_dev_use(dev);
return NULL;
break;
}
@@ -958,6 +959,8 @@
/* allocate an IRQ callback if one is needed */
if ((ss->protocol == US_PR_CBI) && usb_stor_allocate_irq(ss)) {
+ kfree(ss->current_urb);
+ kfree(ss);
usb_dec_dev_use(dev);
return NULL;
}
--
Peter Osterlund - [EMAIL PROTECTED]
http://w1.894.telia.com/~u89404340
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
