On Sat, 12 Jan 2002, Matthew Dharm wrote: > On Sat, Jan 12, 2002 at 10:26:53AM +0100, Peter Osterlund wrote: > > Matthew Dharm <[EMAIL PROTECTED]> writes: > > > > > Hrm... > > > > > > sr.c doesn't have anything to do with writing... that's all done in > > > userspace. Are you using cdrecord? > > > > It does if you apply the packet writing patch. (Which will probably be > > included in the standard kernel in 2.5.) See: > > > > http://www.kernel.org/pub/linux/kernel/people/axboe/packet/ > > http://w1.894.telia.com/~u89404340/patches/packet/ > > Then this should be updated to use the 10-byte commands.
The new code in the packet writing module is only using 10-byte commmands. The problem is the old code in sr.c. > > Maybe the code in sr.c could be changed to use MODE_SENSE_10 instead > > of MODE_SENSE, or at least try the 10-byte version if the 6-byte > > version fails. But that seems more like a workaround. Either > > usb-storage needs to handle MODE_SENSE(6) or it doesn't. Currently, > > the code apparently tries to handle it, but fails in my particular > > case. > > The problem is that the ATAPI devices attached to the bridge are not all > the same. The OnStream drive does not handle 10-byte. The Traveller does. > I guess your device does also. I think my device *is* the Traveller. Would it be feasible to detect this at run-time? Send a MODE_SENSE(6) and if it fails, switch to the MODE_SENSE-conversion protocol. > Honestly, why sr.c still uses the 6-byte commands is beyond me. I > think the proper behavior should be to use the 10-byte, and fallback > on the 6-byte if necessary. Or check the SCSI version number first. I'll ask Jens Axboe about this. Anyway, what would break if you remove the MODE_SENSE/SELECT conversion from the usb_stor_ATAPI_command function? It sounds like nobody should be using the 6-byte commands anyway. -- Peter Osterlund - [EMAIL PROTECTED] http://w1.894.telia.com/~u89404340 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
