On Sun, Jan 13, 2002 at 12:58:45PM +0100, Oliver Neukum wrote: > Hi, > > 1) The check in the write callback will fail in the non error case.
Ah, good catch. > 2) skel_write checks for -EINPROGRESS. This is a race. Yes, but it's a race that _so_ many different drivers have that I don't consider it a driver problem. It should be fixed in the host controller and core, and not have every driver have to implement something like a "writing" flag for every urb. It's on my list of things todo for 2.5. > As we are dealing with an example I'd like to show how to use a waitqueue. > Your oppinions ? Having a good example of a waitqueue would be nice, but I don't see how to add it to the driver, as it is. > 3) Do you think I should add likely/unlikely to the error handling parts ? Not really. It just clutters up the code, and doesn't really help due to most NULL pointer checks are default "unlikely". Almost none of the usb drivers are critical for time right now. But for USB 2.0 devices, this can change. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
