On Tue, 22 Jan 2002, Tim Walberg wrote:

> >>     #include <linux/config.h>
> >>     #include <linux/module.h>
> >>     #include <linux/pci.h>
> >>    @@ -2382,6 +2385,8 @@
> >>            bus = usb_alloc_bus (&sohci_device_operations);
> >>            if (!bus) {
> >>                    kfree (ohci);
> >>    +               pci_set_drvdata(dev, NULL);
> >>    +               pci_free_consistent(ohci->ohci_dev, sizeof *ohci->hcca, 
>ohci->hcca, ohci->hcca_dma);
> >>                    return NULL;
> >>            }
> >>    
> 
> 
> I suspect this part is an OOPS waiting to happen - better
> not kfree(ohci) until after pci_free_consistent(...), I think.

Ugh.  I don't know what I was thinking when I did that part.  What's the
proper methodology for patch resubmission?  Just fix and resend?

Matthew Fredrickson



_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to