On Friday 01 February 2002 00:45, Alan Cox wrote:
> > auerswald.c did a direct access to current->state. This potentially
> > unsafe on SMP. Here is the fix.
>
> Should be fine actually. The function call is a synchronization point so
> the compiler will write it out. Paranoia rarely hurts except in very
> critical paths though
Will the compiler do this even if a function is static ?
On a related note, is code like this:
if (list->head == list->tail) {
add_wait_queue(&list->evdev->wait, &wait);
current->state = TASK_INTERRUPTIBLE;
while (list->head == list->tail) {
from evdev.c safe ?
Might the compiler decide to optimise away the check in while(...)
at least on the first iteration ?
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
