What's to complain about? :)
Yes, that looks like it does the right thing.
- Dave
----- Original Message -----
From: "Oliver Neukum" <[EMAIL PROTECTED]>
To: "David Brownell" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
Sent: Sunday, February 03, 2002 3:11 PM
Subject: Re: [linux-usb-devel] first version of gfp additions
> On Sunday 03 February 2002 20:03, David Brownell wrote:
> > This is missing one hcd.c update ... hcd_submit_urb()
> > should be taking a "mem_flags" argument. Then, delete
> > the FIXME comment above the current mem_flags init,
> > and the mem_flags init itself.
> >
> > Passing mem_flags (like GFP_NOIO) down through the
> > HCD layer (to ehci-hcd and ohci-hcd) will then work as
> > needed, since the HCD framework already passes that
> > flag along.
>
> Splendid Planing !
>
> Do you like the incremental patch ?
>
> Regards
> Oliver
>
> --- hcd.c.i Mon Feb 4 00:04:56 2002
> +++ hcd.c Mon Feb 4 00:09:05 2002
> @@ -916,14 +916,13 @@
> /* may be called in any context with a valid urb->dev usecount */
> /* caller surrenders "ownership" of urb (and chain at urb->next). */
>
> -static int hcd_submit_urb (struct urb *urb)
> +static int hcd_submit_urb (struct urb *urb, int mem_flags)
> {
> int status;
> struct usb_hcd *hcd;
> struct hcd_dev *dev;
> unsigned long flags;
> int pipe;
> - int mem_flags;
>
> if (!urb || urb->hcpriv || !urb->complete)
> return -EINVAL;
> @@ -946,11 +945,6 @@
> if (usb_endpoint_halted (urb->dev, usb_pipeendpoint (pipe),
> usb_pipeout (pipe)))
> return -EPIPE;
> -
> - // FIXME paging/swapping requests over USB should not use GFP_KERNEL
> - // and might even need to use GFP_NOIO ... that flag actually needs
> - // to be passed from the higher level.
> - mem_flags = in_interrupt () ? GFP_ATOMIC : GFP_KERNEL;
>
> #ifdef DEBUG
> {
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
