FYI: I find that patch format hard to use/read -- have to edit the email and remove the "#" prefixes before it applies or can be read.
I'm glad to see some more fixes to kaweth. I'm curious why the new block-til-unlink code is only in disconnect() though. There may be lurking bugs there; kaweth has had a slightly tortured history. :) It looks like taking an interface down from the command line is unnecessarily different from taking it down by unplug. Wouldn't it be better to just block in close(), and rely on the unregister_netdev() call in disconnect to manage all the I/O shutdown? (It closes open devices.) Also, I suspect it'd be better to use "struct completion" synchronization objects rather than waitqueues. In part that's a correctness concern. Classically, the idiom is "reschedule till done", and those objects encapsulate that logic (which is omitted in this patch). - Dave _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
