On Wed, Feb 13, 2002 at 11:30:35PM +0100, Martin Diehl wrote: > > Yes, I do totally agree with David: there is absolutely _no_ debounce > interval (connect-detect-to-port-reset) implemented in 2.4.18-pre9 hub.c > According to USB 7.1.7.1 this is mandatory and must be TATTDB > 100 ms. > It is also shown in fig. 7-19 of the USB 1.1 specs (I'm validating > vs. 1.1). The mentioned 400ms delay for low speed devices is just were the > debounce delay should be.
Good catch. I'll send out a patch in a bit to fix this. > Btw. another concern wrt. to this code from hub.c is, there are several > places calling usb_get_port_status passing a pointer to a stack-located > struct usb_port_status - which becomes the transfer_buffer for the > usb_control_msg) call. Mapping stack locations for PCI-DMA however is > invalid. I'm wondering whether we could simply have shared buffer for this > allocated from khubd instead of spending much effort to alloc/check/free > such stuff at many places. Bleah, yes this should be fixed. Patches _gladly_ accepted for this problem. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
