On Thu, Feb 21, 2002 at 08:30:48PM -0800, David Brownell wrote:
> Hi Greg,
>
> This is another API cleanup patch. It's against 2.5.5:
I did make this minor change on top of your patch. I don't like to have
header files that include other header files :)
So I put back the #include <linux/pci.h> in hcd.c and removed it from
hcd.h.
I see what you are trying for, but hcd.c is still pretty PCI oriented.
I'd like to have that depandency removed for those platforms that do not
need it. Ideally the usbcore should be able to be compiled with
CONFIG_PCI turned off.
thanks,
greg k-h
diff -Nru a/drivers/usb/hcd.c b/drivers/usb/hcd.c
--- a/drivers/usb/hcd.c Fri Feb 22 15:43:46 2002
+++ b/drivers/usb/hcd.c Fri Feb 22 15:43:46 2002
@@ -24,6 +24,7 @@
#include <linux/config.h>
#include <linux/module.h>
+#include <linux/pci.h>
#include <linux/kernel.h>
#include <linux/delay.h>
#include <linux/ioport.h>
diff -Nru a/drivers/usb/hcd.h b/drivers/usb/hcd.h
--- a/drivers/usb/hcd.h Fri Feb 22 15:43:46 2002
+++ b/drivers/usb/hcd.h Fri Feb 22 15:43:46 2002
@@ -165,8 +165,8 @@
extern void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb);
#ifdef CONFIG_PCI
-#include <linux/pci.h>
-
+struct pci_dev;
+struct pci_device_id;
extern int usb_hcd_pci_probe (struct pci_dev *dev,
const struct pci_device_id *id);
extern void usb_hcd_pci_remove (struct pci_dev *dev);
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
