I sent this patch to you as a reply to another message and it appears
that you didn't pick it up immediately since it's not in 2.4.19-pre5.

The patch ensures that uhci.c doesn't use urb->status after the
completion callback if it doesn't need to. This is important if drivers
delete the URB in the completion handler.

The patch is actually relative to 2.4.19-pre3 plus some of my other
patches, but it will apply to 2.4.19-pre5 with a little fuzz.

JE

--- linux-2.4.19-pre3.orig/drivers/usb/uhci.c   Sun Mar 17 21:43:12 2002
+++ linux-2.4.19-pre3/drivers/usb/uhci.c        Sun Mar 17 21:42:06 2002
@@ -2350,15 +2351,15 @@
        urb->dev = NULL;
        spin_unlock_irqrestore(&urb->lock, flags);
 
-       if (urb->complete) {
+       if (urb->complete)
                urb->complete(urb);
 
+       if (resubmit_interrupt)
                /* Recheck the status. The completion handler may have */
                /*  unlinked the resubmitting interrupt URB */
                killed = (urb->status == -ENOENT ||
                          urb->status == -ECONNABORTED ||
                          urb->status == -ECONNRESET);
-       }
 
        if (resubmit_interrupt && !killed) {
                urb->dev = dev;

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to