On Tue, 2 Apr 2002 10:19, Greg KH wrote:
> On Mon, Apr 01, 2002 at 11:37:01PM +0200, Vojtech Pavlik wrote:
> > On Mon, Apr 01, 2002 at 01:33:27PM -0800, Greg KH wrote:
> > > Should this also be added to 2.5?
> >
> > Yes, please.
>
> Ok, I had to hand edit it, but I applied it to the 2.5 tree.
>
> In looking at the code, I realized that the following patch could reduce
> the use of the #ifdefs in the code. In the end all that happens is a
> change to hid.h, the hid-core.c patch is just backing out Brad's
> changes. Is it ok for me to make this change?
I personally find this sort of thing unneccessarily subtle.
The #ifdef is perfectly clear ("OK, the behaviour depends on a couple of
CONFIG options..."), isn't really that ugly, and there isn't much difference
between having the code removed by the pre-processor or the optimiser.
However if you are going to do it at all, I think you should do it for the
HIDDEV and HIDINPUT cases equally.
Brad
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
