On Mon, Apr 01, 2002 at 11:32:25PM -0800, Stuart Lynne wrote:
> The Linux USB Device software developed by Lineo, currently being used
> by Sharp for the Zaurus, has been released under a GPL license and is
> available at:
Yeah! Thanks for releasing this code, I am very happy to see it.
A few questions:
- do you want me to add this to the main kernel tree? It should
probably go somewhere like drivers/usb/device. I can whip up
an initial patch to the 2.5 tree is you want me to (which
would involve fixing all of the formatting issues, but that's
what Lindent is for :)
- can I add the safe_serial driver to the tree? I have had some
people ask me about something like this in the past, thanks
for writing it.
- You don't need to create your own MIN() and MAX macros, the
kernel now provides some typesafe versions.
- it looks like your usbd api is close to the same as the
existing usb api. Why not make it even closer to help provide
some "familiarity" when writing drivers for both sides of the
wire? For example, usbd_alloc_urb() takes 4 parameters, while
usb_alloc_urb() takes 2.
- you should add a reference count to the struct urb. It will
save you many headaches in the future (read Chapter 8 in
CodingStyle).
- thanks for adding the hotplug interface, I appreciate it :)
That's probably enough for now.
thanks,
greg k-h
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
