>>       You should also delete the line that calls skb_reserve.

>I think it should be there.  Otherwise the first time read_bulk_callback
>is called the socket buffer will not be attached to the appropriate
>device

        I don't know what you are referring to above.  You should keep
the line that says "dev->rx_skb->dev = netdev;"  I just want you to
delete both lines that say "skb_reserve(dev->rx_skb, 2);"

>neither the padding 2 bytes will be reserved.

        What is the purpose of that?

>Or you have something else in mind? The driver is working fine so far.

        I run the driver with no skb_reserve calls and it works fine
for me (and alloc_skb does not appear to reserve any bytes at the
front by default, in case you think that is why it is working for me).
I am ssh'ed in from a computer running that driver right now.

        What is the purpose of reserving two bytes at the front of
the skbuff?  I don't see them being used anywhere.

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED]     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to