On Wed, Apr 03, 2002 at 06:55:19PM -0800, Greg KH wrote: > On Wed, Apr 03, 2002 at 07:21:21PM -0700, Patrick J. Kobly wrote: > > I'm sending this out now, so that I can get comments, recommendations and > > device ID's for Samsung MP3 players that I may be able to support.
> Is there any reason this has to be a kernel driver? Can't you just use > usbfs or libusb to talk to the device just as easily? Correct me if I'm wrong, but don't apps which use libusb need to be setuid root? At least with an in-kernel driver, we limit privileged code to only the code in the kernel driver, where with libusb, we have more setuid user-apps, each of which needs to be carefully checked for buffer overflows and other vulnerabilities. (This is _the_ reason that I don't like the solution taken for CD-R's under linux - use sg, set cdrecord setuid or run it as root) > You are also using some minor numbers that are already taken by other > USB drivers, not nice :) :(. It could definitely be advantageous to register one. I can't realistically see a demand for more than one of these connected at once. (And the driver currently does not support it.) PK
msg05629/pgp00000.pgp
Description: PGP signature
