[linux-usb-devel] catc: GFP_KERNEL in interrupt or with spinlocks held

[Oliver Neukum]

Hi Vojtech,

bad usage of mem_flags in catc.

        Regards
                Oliver
--- catc.c.alt  Wed Apr 10 20:11:53 2002
+++ catc.c      Wed Apr 10 20:19:56 2002
@@ -278,7 +278,7 @@
                        atomic_dec(&catc->recq_sz);
                        dbg("getting extra packet");
                        urb->dev = catc->usbdev;
-                       if ((status = usb_submit_urb(urb, GFP_KERNEL)) < 0) {
+                       if ((status = usb_submit_urb(urb, GFP_ATOMIC)) < 0) {
                                dbg("submit(rx_urb) status %d", status);
                        }
                } else {
@@ -329,7 +329,7 @@
                                atomic_inc(&catc->recq_sz);
                } else {
                        catc->rx_urb->dev = catc->usbdev;
-                       if ((status = usb_submit_urb(catc->rx_urb, GFP_KERNEL)) < 0) {
+                       if ((status = usb_submit_urb(catc->rx_urb, GFP_ATOMIC)) < 0) {
                                err("submit(rx_urb) status %d", status);
                        }
                } 
@@ -351,7 +351,7 @@
        catc->tx_urb->transfer_buffer = catc->tx_buf[catc->tx_idx];
        catc->tx_urb->dev = catc->usbdev;
 
-       if ((status = usb_submit_urb(catc->tx_urb, GFP_KERNEL)) < 0)
+       if ((status = usb_submit_urb(catc->tx_urb, GFP_ATOMIC)) < 0)
                err("submit(tx_urb), status %d", status);
 
        catc->tx_idx = !catc->tx_idx;

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel