On Thursday 11 April 2002 22:52, Petko Manolov wrote:
> > the rx urb twice, in the completion handler and in the tasklet ?
>
> Ahum, no. Rx urb is resubmited only if there is available sk_buff
> _and_ default Rx urb (dev->rx_urb) == NULL. Which is the right thing
> to do. Instead I've found possible memory leak in rx_fixup after
> looking at ti closely. :-)
>
> > Further you still don't solve the issue of rx dying due to low memory
> > in urb submission.
>
> Yes, kind of. I kill it if dev->rx_urb is zero which is supposed to be
> fixed by the tasklet. This may only happen if read_bulk_callback is
> called twice before the tasklet get executed. I moved this check below
> the tasklet reschedule.
It still is insufficient IMHO.
The tasklet will safe you if you could not allocate rx_skb.
It will not safe you if usb_submit_urb() itself fails.
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
