On Friday 12 April 2002 17:17, you wrote:
> Oliver Neukum wrote:
> > On Friday 12 April 2002 02:44, you wrote:
> >>OK, this is the final patch which should cover the case we are
> >>low on memory and if usb_submit_urb() fail. Comments?
> >
> > I'd like to see the patch. Would you please include it ? ;-)
>
> Here we go again. :-)
OK. I got it.
1. Why do you schedule the tasklet unconditionally ?
IMHO draining the pool about 50% and then refill it in
one go would be much more efficient.
2. You cannot assume that submission in the tasklet will work
if it failed in the completion handler. In fact the opposite is likely.
3. The handling for errors in urb->status in the rx path looks fishy.
There's a code path in which you don't schedule the tasklet.
4. Where is the handling for unlinking the urb in the completion handler ?
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
