On Fri, Apr 12, 2002 at 04:27:42PM -0700, Stuart Lynne wrote:
> On Fri, Apr 12, 2002 at 02:18:15PM -0700, Greg KH wrote:
> > Hi all,
> >
> > I've gotten the Lineo USB Device code merged into the main kernel tree.
> > It can be seen at:
> > bk://linuxusb.bkbits.net/usbd-2.5
>
> Have bk, havn't played with it yet.....
>
> What magic incantation will be best to grab a copy.
bk clone bk://linuxusb.bkbits.net/usbd-2.5 usbd-2.5
will create a subdirectory with the whole tree.
> Is this a patch against 2.5 or ?
It is Linus's 2.5 bitkeeper tree with the usbd code added.
> Currently I'm doing everything in 2.4.XX, will this work in a 2.4.XX
> tree if I move it there (i.e. does the current 2.5 USB user or rely
> on any 2.5 only features?)
If you move the entire drivers/usb/ tree into 2.4, it might work, don't
know. I just moved all of the files around in the drivers/usb/
directory in 2.5 in anticipation of adding these changes. And I don't
think this code will be backported until it stabilizes, which I think
will take a while.
> > I've added the source files under the drivers/usb/device directory, made
> > the code match Documentation/CodingStyle (mostly, there's still some
> > work to be done there...), fixed all of the Config.in entries to be in
> > the proper CodingStyle format, added Config.help entries, and integrated
> > the code into the main kernel build process.
>
> The only thing I object to is 80 character lines...
Me too, and that limitation isn't in CodingStyle :)
My version of Lindent is:
indent -kr -i8 -npsl -pcs -l100 -lc120
which still follows CodingStyle. Sometimes I bump up -l and -lc
options, depending on the code. This is what I ran on the usbd code
(basically you were not using tabs properly, everything else looked
good.)
thanks,
greg k-h
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
