> > p.p.s. Driver-visible API change in 2.5.10: if you use > > fops, you MUST set num_minors ... listing in the > > /proc/bus/usb/drivers file happens even if there's > > no way the driver will be accessible. I think it'd be > > better to fail the registration if num_minors is zero > > for a driver using fops. > > Do you see any drivers in the tree that are doing this?
No, I had a driver out-of-tree that I use for testing, and it blew up silently. That is, silently till I stuck a bunch of debug printfs and to find out what was going wrong. > I thought I > fixed them all. If a driver doesn't specify num_minors, they do not get > a minor, it's that simple. I think the author will figure that one out > quick enough :) It's not quite simple enough, since by all the usual indicators the driver is properly hooked up. Hence my suggestion to sanity check "if (driver->fops && !driver->num_minors) fail()". - Dave _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
