> > Devfs goes the whole way.
> > Let's look at the basic function of major:minor combinations.
> > You use them to assign names and permissions to a device.
> > If minors become dynamic minors no longer have any function,
> > you are better of eliminating them.
>
> I would love to eliminate minors, but can't due to the current system.
> If the core of the kernel that handles major/minor numbers changes, then
> I will change USB to match that. But for today, this is what is needed
> for large number of devices.
Partially. In a machine with a few PCI slots, you still could overwhelm
the new scheme. As I see it, you still are working around an issue.
> > What is the loop supposed to do then ?
> > It has some comments about looking internally for a minor.
>
> That loop executes if CONFIG_USB_DYNAMIC_MINORS is NOT enabled. It's
> the existing way of finding a minor number for a device. I'm not
> changing that logic at all, just moving it within a if() call. This
> way, if CONFIG_USB_DYNAMIC_MINORS is not enabled, the driver falls back
> to the original way of handling its minors.
But you do. That loop will trigger in the error case and happily assign
any random number. If you are responsible for an #IFDEF , don't hide it.
In other words, run out of minors and you are screwed.
> Remember, devfs does not remove our need for minor numbers. It just
But it handles them dynamically. Which is the best you can do
with the present architecture. I repeat, a dynamic minor makes
the concept of a minor meaningless and reduces it to feature
of backwards compatibility.
> imposes a naming scheme on the kernel for the major/minor pairs that
> happen to be present in the system at a moment in time. This patch is
> still needed to extend our usage of the USB minor range.
If you did use devfs to the extent it can be used, you could have 256
devices of all types.
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
