On Sun, May 12, 2002 at 07:27:57PM -0700, Randy.Dunlap wrote:
> On Tue, 7 May 2002, Greg KH wrote:
> 
> | diff -Nru a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
> | --- a/drivers/usb/input/hid-core.c  Tue May  7 15:18:26 2002
> | +++ b/drivers/usb/input/hid-core.c  Tue May  7 15:18:26 2002
> | @@ -1398,7 +1398,7 @@
> 
> | -           snprintf(hid->name, 64, "%04x:%04x", dev->descriptor.idVendor, 
>dev->descriptor.idProduct);
> | +           snprintf(hid->name, 128, "%04x:%04x", dev->descriptor.idVendor, 
>dev->descriptor.idProduct);
> 
> why not use sizeof() instead?
> 
> |+            snprintf(hid->name, sizeof(hid->name), "%04x:%04x",
> |+                    dev->descriptor.idVendor, dev->descriptor.idProduct);

I don't know, it looks like it would make more sense to do that.

Vojtech, any reason not to change this?

thanks,

greg k-h

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [EMAIL PROTECTED]
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to