> After maturing for more than a month, I decided that it's enough... > So here's the patch for the HCD-version of usb-uhci, I called it > usb-uhci-hcd. For me, the usual devices work (TM).
Cool! I built it, saw a smaller object size (by about a page), and glanced quickly at the code. I'll try using it later. That defibrillator seems useful, and I like the name ... :) > More comments and the separation into multiple files (I've taken ohci-hcd as > an example) should make the code more concise... It can become a bit slimmer still, though. Do you really need both the "dbg.c" and "debug.h"? It's not leveraging all the request cleanup done in the layer above -- like forcing periodic transfer intervals to be a power of two. And the urb->next stuff should go too ... if that remains at all, it belongs in the hcd framework code, not inside the individual HCDs. It shouldn't force CONFIG_USB_DEBUG on if it's already set, but it's just a simple tweak to get rid of that warning. - Dave _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
