On Tue, May 14, 2002 at 10:05:40AM -0700, David Brownell wrote: > > > > How about this. Given mine and Johannes's patches, do you see any > > > > problems in the code? Does it break anything? > > > > > > Yes, as I noted separately. Move the deallocate() call and > > > it'll behave though. > > > > Sorry, but to where (missed that one.) > > > > A patch would show it better :) > > See the attached ... it re-fixes that bug in those recent patches. > > Now a routine that's not allowed to be called with a thread context > can't be called in_interrupt() any longer, even given buggy device > drivers that don't disconnect() correctly.
Sorry for the delay, got busy at work. Anyway, I don't understand how this patch changes anything. The call to usb_put_dev() right below the place you patched usb_disconnect() would do all of the cleanup that you just added to the function. Are you trying to separate the hardware specific portions of the device from the "logical" portions? (I think this is your main point, right?) If so, this patch _might_ work, but I'd like to get Johannes to look at it in light of uhci.c. thanks, greg k-h _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
