>>>>> "Johannes" == Johannes Erdfelt <[EMAIL PROTECTED]> writes:
Johannes> There's a couple of places where you allocate memory,
Johannes> but don't check to see if it succeeded. That's bad.
Good point ... I will fix that.
Johannes> Also, I'm not sure what your patch to usb_get_descriptor
Johannes> is for:
Johannes> All of the uses of usb_get_descriptor in usb.c are
Johannes> safe. I'd much rather make the calling routine require a
Johannes> DMA capable buffer than in usb_get_descriptor.
I'm not sure why I thought there were unsafe uses of
usb_get_descriptor(). Somehow I convinced myself that there were a
ton of unsafe callers and that it was just easier to hack
usb_get_descriptor(). I'll check on that and fix any unsafe callers
instead.
Thanks for the comments. I'll make the changes you suggested and post
a new version (as soon as my colleague gives me the 440GP board back so
I can test).
Roland
_______________________________________________________________
Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -
http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
