On Tue, Jul 09, 2002 at 11:48:38PM +0200, Oliver Neukum wrote:
> Hi,
> 
> the recent discussion on the BKL made me check whether the BKL
> really leads to bad locking. Most uses of BKL in drivers/usb/core
> are in usbfs.
> 
> I am afraid the guy claiming that was not totally removed from
> reality.
> 
> - devio.c::usbdev_open
> 
> Here we have an open with no protection at all against reentrancy.
> The comment is absolutely bogus as open can sleep. Very bad.

I agree, not good.  I've been avoiding looking at devio.c due to my urge
to change the way the whole usbfs user interface works :)

But patches gladly accepted to clean it up to be as race free as
possible :)

thanks,

greg k-h


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Stuff, things, and much much more.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to