Dear Linux kernel code maintainer, on rechecking the current stable kernel code, I found some places where jiffies were compared in a way that seems to break when they wrap. For these, I made up patches to use the macros "time_before()" or "time_after()" that are supposed to handle wraparound correctly.
For a small part of the patches, I believe you to be the relevant kernel code maintainer. Appended to this email you will find some lines explaining why I decided to mail or cc: you on this (an extract of the copyright notice or the MAINTAINERS file), followed by the patch itself. If I mailed you in error, please drop me a short note. I kindly ask you to approve the correctness of the patch, and pass it on to the relevant people for inclusion into the mainline kernel. Thanks, Tim Schmielau ([EMAIL PROTECTED]) USB MASS STORAGE DRIVER P: Matthew Dharm M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained W: http://www.one-eyed-alien.net/~mdharm/linux-usb/ --- linux-2.4.20-pre6/drivers/usb/storage/sddr55.c Wed Sep 11 13:36:57 2002 +++ linux-2.4.20-pre6-jfix/drivers/usb/storage/sddr55.c Wed Sep 11 13:00:45 2002 @@ -968,7 +968,7 @@ /* only check card status if the map isn't allocated, ie no card seen yet * or if it's been over half a second since we last accessed it */ - if (info->lba_to_pba == NULL || jiffies > (info->last_access + HZ/2)) { + if (info->lba_to_pba == NULL || time_after(jiffies, info->last_access + HZ/2)) +{ /* check to see if a card is fitted */ result = sddr55_status (us); ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
