I have not looked at this at all, maybe this is nonsense,
but at very first sight, when I see this patch, with code like
result = usb_storage_bulk_transport(us, SCSI_DATA_READ,
buf, bulklen, 0);
- if (result != USB_STOR_TRANSPORT_GOOD)
+ kfree(buf);
+ if (result != USB_STOR_XFER_GOOD) {
US_DEBUGP("Result for bulk_transport in sddr09_read_sg %d\n",
result);
+ return USB_STOR_TRANSPORT_ERROR;
+ }
- kfree(buf);
-
- return result;
+ return USB_STOR_TRANSPORT_GOOD;
it looks like information is being thrown away. Some low level
routine returns a result, and earlier we reported this result
to higher levels. But this patch changes the result codes
used by the lower levels, which means that we no longer can
transmit result codes, and the code is reduced to a simplistic
"did he say it was OK? Then return OK. Otherwise return ERROR".
Often it is useful to have more detailed information.
For example, a short transport can be OK.
Andries
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
