On Wed, Sep 25, 2002 at 05:46:12PM -0700, Matthew Dharm wrote: > On Thu, Sep 26, 2002 at 02:33:50AM +0200, Andi Kleen wrote: > > David Brownell <[EMAIL PROTECTED]> writes: > > > > > > + /* stuff we want to pass to /sbin/hotplug */ > > > > + envp[i++] = scratch; > > > > + scratch += sprintf (scratch, "PCI_CLASS=%04X", pdev->class) + 1; > > > > + > > > > + envp[i++] = scratch; > > > > + scratch += sprintf (scratch, "PCI_ID=%04X:%04X", > > > > + pdev->vendor, pdev->device) + 1; > > > > > > And so forth. Use "snprintf" and prevent overrunning those buffers... > > > > Hmm? An %04X format is perfectly bounded. > > Technically, it isn't bounded. The field will expand if the value exceeds > 4 digits.
It is bounded to 8 characters on linux systems (where int is always 32bit) -Andi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
