Greg -- Thisis another patch for usb-storage. Apparently, ide_fix_driveid() isn't always available. We either need this patch or need to convince folks to make ide_fix_driveid() available on all arches.
Matt
----- Forwarded message from Bj�rn Stenberg <[EMAIL PROTECTED]> -----
Date: Thu, 26 Sep 2002 17:57:38 +0200
From: Bj�rn Stenberg <[EMAIL PROTECTED]>
Subject: Re: [usb-storage] [PATCH] ata_fix_driveid in isd200 driver
To: Matthew Dharm <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED], [EMAIL PROTECTED]
X-Spam-Status: No, hits=-10.0 required=5.0 tests=IN_REP_TO,UNIFIED_PATCH version=2.11
Bj�rn Stenberg wrote:
> Matthew Dharm wrote:
> > Does this mean that the isd200 driver still needs the IDE subsystem
> > compiled in?
>
> ide_fix_driveid() is an empty macro for all systems except PPC, where it
> is implemented independently from the IDE subsystem. So the answer is "no".
It seems I was wrong about this. PPC and SPARC64 do need the IDE subsystem.
Here's a Config.in patch to handle the differing dependencies.
--
Bj�rn
--- linux-2.5.34/drivers/usb/storage/Config.in~ 2002-09-09 19:35:06.000000000 +0200
+++ linux-2.5.34/drivers/usb/storage/Config.in 2002-09-26 17:54:42.000000000 +0200
@@ -8,7 +8,11 @@
dep_mbool ' USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG
$CONFIG_USB_STORAGE
dep_mbool ' Datafab Compact Flash Reader support (EXPERIMENTAL)'
CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
dep_mbool ' Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM
$CONFIG_USB_STORAGE
- dep_mbool ' ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200
$CONFIG_USB_STORAGE
+ if [ "$CONFIG_PPC" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
+ dep_mbool ' ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200
+$CONFIG_USB_STORAGE $CONFIG_IDE
+ else
+ dep_mbool ' ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200
+$CONFIG_USB_STORAGE
+ fi
dep_mbool ' Microtech CompactFlash/SmartMedia support' CONFIG_USB_STORAGE_DPCM
$CONFIG_USB_STORAGE
dep_mbool ' HP CD-Writer 82xx support (EXPERIMENTAL)'
CONFIG_USB_STORAGE_HP8200e $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
dep_mbool ' SanDisk SDDR-09 (and other SmartMedia) support (EXPERIMENTAL)'
CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
----- End forwarded message -----
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
Hey, has anyone seen the Microsoft sales guy? It's his feeding time...
-- Mike
User Friendly, 4/17/1998
msg08139/pgp00000.pgp
Description: PGP signature
