> Attached is a patch against 2.5.40 with __dev* uses removed and the error > checking in the open routine fixed. > > Let me know if the ordering of the video_unregister_device and tasklet_kill > is still an issue.
It isn't. But the disconnect is still wrong. You fail to unlink the current urb. This has to be done before you kill the tasklet. And you have to use a flag and a spinlock to guard against a race with the completion handler. There's a recent discussion on this in the usb archives. And you need to defer freeing the memory if the device is open. Have a look at how pwc does it. It should be correct in that regard. And while you at it, could you rename the tasklet from ...bh... to ...tl... ? It's no longer a bottom half. Regards Oliver ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel