Am Montag, 14. Oktober 2002 02:04 schrieb Greg KH:
> On Sun, Oct 13, 2002 at 03:36:04PM +0200, Oliver Neukum wrote:
> > Hi,
> >
> > David's remark about documenting the locking needed between
> > usb_Set_configuration() and probe() caused me to look through
> > other parts of usbcore.
> >
> > Well, sadly I found some.
> >
> > Races with disconnect:
> > All synchronous operations (usb_reset_device, usb_clear_halt, ...)
>
> Hm, any pointers to the problem area?
URBs are not properly unlinked. That cannot be done, as nobody has
an external handle on these URBs.
> > Races with probe:
> > usb_reset_device, a probe while resetting is bound to malfunction
>
> Like David said, I don't think this is a problem.
Then usb_reset_device() should be removed from usbcore and added
to the storage driver.
> > Would anybody object to solve this with proper locking ?
> > Would anybody object to changing the semaphore in usb_device
> > into an rw semaphore ?
>
> How about droping the semaphore all together and using the lock in the
> struct device portion?
There is no semaphore in struct device, at least in the tree I have currently
on disk. I am afraid I do not understand how you want me to do that.
Regards
Oliver
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
